test: stabilize source regression assertions for current UI by BigSimmo · Pull Request #805 · BigSimmo/Database

BigSimmo · 2026-07-17T21:46:00Z

Summary

Update source-level regression tests for current services/forms UI source behavior.
Remove stale selector assertions that no longer match refactored pages.
Keep source-provenance coverage focused and resilient to intentional copy changes.

Verification

npx vitest run tests/audit-content-services-regressions.test.ts tests/audit-navigation-auth-regressions.test.ts => 2 passed, 11 passed (11)
npx prettier --write tests/audit-content-services-regressions.test.ts tests/audit-navigation-auth-regressions.test.ts
npx verify:cheap — not run (outside this test-only fix scope; may require longer runtime)

supabase · 2026-07-17T21:46:06Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2026-07-17T21:46:32Z

📝 Walkthrough

Walkthrough

The PR updates audit regression tests for service comparison, seeded form provenance, source-link rendering, private API gating, polling and mutation contracts, and the root dashboard heading.

Changes

Content-service audit updates

Layer / File(s)	Summary
Service navigator and seeded form contracts `tests/audit-content-services-regressions.test.ts`	Assertions now cover comparison selection strings, sanitized form provenance metadata, confirmation-required statuses, updated forms-page content, and official-source labels.
Form source-link rendering `tests/audit-content-services-regressions.test.ts`	Source-link checks now validate pending-source text, optional URLs, and an official-source anchor.

Navigation and authentication audit updates

Layer / File(s)	Summary
Private gating and dashboard heading `tests/audit-navigation-auth-regressions.test.ts`	Assertions now check `canUsePrivateApis`, `localNoAuthMode`, updated polling and mutation source conditions, and the root “Clinical KB” heading.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

BigSimmo/Database#560: Related services-navigator comparison and sorting behavior.
BigSimmo/Database#687: Related private/authentication gating and routed search behavior.
BigSimmo/Database#735: Related dashboard and PWA interaction updates.

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title is concise and accurately reflects the test-focused source-regression stabilization in this PR.
Description check	✅ Passed	The description covers summary and verification clearly, and the missing rollout/governance sections are reasonable for a test-only change.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/fix-form-tests-main

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/audit-content-services-regressions.test.ts`:
- Around line 206-207: Update the normalizedFormDetailSource matcher in the
anchor-label regression test so the pattern cannot cross the closing </a> tag
before matching “Official”. Keep the assertion focused on the <a
href={form.source.url}> element and require “Official” within that anchor’s
contents; retain the separate formDetailSource containment check only if it
remains necessary.

In `@tests/audit-navigation-auth-regressions.test.ts`:
- Around line 124-126: Update the heading assertion in the “keeps the root
dashboard H1 as Clinical KB” test to match only the exact “Clinical KB” text,
removing the alternation that also permits “Clinical Guide”; preserve the
existing H1 structure and whitespace handling.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5b467aa4-640f-4c68-ba06-405f6c856959

📥 Commits

Reviewing files that changed from the base of the PR and between 0b6e020 and 042bb2b.

📒 Files selected for processing (2)

tests/audit-content-services-regressions.test.ts
tests/audit-navigation-auth-regressions.test.ts

coderabbitai · 2026-07-17T21:49:59Z

+    expect(normalizedFormDetailSource).toMatch(/<a href=\{form\.source\.url\}[^>]*>[\s\S]*Official/);
+    expect(formDetailSource).toContain("Official");


🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Constrain “Official” to the source URL anchor.

This matcher can cross </a> and pass on an unrelated later “Official” string, so it does not reliably protect the anchor label contract.

Proposed fix

- expect(normalizedFormDetailSource).toMatch(/<a href=\{form\.source\.url\}[^>]*>[\s\S]*Official/); + expect(normalizedFormDetailSource).toMatch( + /<a href=\{form\.source\.url\}[^>]*>(?:(?!<\/a>)[\s\S])*Official/, + );

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

expect(normalizedFormDetailSource).toMatch(/<a href=\{form\.source\.url\}[^>]*>[\s\S]*Official/);

expect(formDetailSource).toContain("Official");

expect(normalizedFormDetailSource).toMatch(

/<a href=\{form\.source\.url\}[^>]*>(?:(?!<\/a>)[\s\S])*Official/,

);

expect(formDetailSource).toContain("Official");

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/audit-content-services-regressions.test.ts` around lines 206 - 207, Update the normalizedFormDetailSource matcher in the anchor-label regression test so the pattern cannot cross the closing </a> tag before matching “Official”. Keep the assertion focused on the <a href={form.source.url}> element and require “Official” within that anchor’s contents; retain the separate formDetailSource containment check only if it remains necessary.

coderabbitai · 2026-07-17T21:49:59Z

+  it("keeps the root dashboard H1 as Clinical KB", () => {
    expect(clinicalDashboardSource.match(/<h1\b/g)).toHaveLength(1);
-    expect(clinicalDashboardSource).toMatch(/<h1 className="sr-only">\s*Clinical Guide\s*<\/h1>/);
+    expect(clinicalDashboardSource).toMatch(/<h1 className="sr-only">\s*Clinical (?:Guide|KB)\s*<\/h1>/);


🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Require the exact Clinical KB heading.

This regex accepts the old Clinical Guide value, so the test passes against the supplied src/components/ClinicalDashboard.tsx implementation even though the test name requires Clinical KB. Use an exact Clinical KB match, or retain an exact Clinical Guide expectation if no UI change is intended.

Proposed fix

- expect(clinicalDashboardSource).toMatch(/<h1 className="sr-only">\s*Clinical (?:Guide|KB)\s*<\/h1>/); + expect(clinicalDashboardSource).toMatch(/<h1 className="sr-only">\s*Clinical KB\s*<\/h1>/);

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

it("keeps the root dashboard H1 as Clinical KB", () => {

expect(clinicalDashboardSource.match(/<h1\b/g)).toHaveLength(1);

expect(clinicalDashboardSource).toMatch(/<h1 className="sr-only">\s*Clinical Guide\s*<\/h1>/);

expect(clinicalDashboardSource).toMatch(/<h1 className="sr-only">\s*Clinical (?:Guide|KB)\s*<\/h1>/);

it("keeps the root dashboard H1 as Clinical KB", () => {

expect(clinicalDashboardSource.match(/<h1\b/g)).toHaveLength(1);

expect(clinicalDashboardSource).toMatch(/<h1 className="sr-only">\s*Clinical KB\s*<\/h1>/);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/audit-navigation-auth-regressions.test.ts` around lines 124 - 126, Update the heading assertion in the “keeps the root dashboard H1 as Clinical KB” test to match only the exact “Clinical KB” text, removing the alternation that also permits “Clinical Guide”; preserve the existing H1 structure and whitespace handling.

BigSimmo added 2 commits July 18, 2026 05:41

test: align source-level regression assertions with updated forms UI

a84a8f2

test: stabilize source-level assertions for current UI strings

5ec5ba2

chore: sync branch with latest main before merge

042bb2b

BigSimmo enabled auto-merge (squash) July 17, 2026 21:46

BigSimmo merged commit 0957415 into main Jul 17, 2026
15 of 18 checks passed

BigSimmo deleted the codex/fix-form-tests-main branch July 17, 2026 21:49

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: stabilize source regression assertions for current UI#805

test: stabilize source regression assertions for current UI#805
BigSimmo merged 3 commits into
mainfrom
codex/fix-form-tests-main

BigSimmo commented Jul 17, 2026 •

edited

Loading

Uh oh!

supabase Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jul 17, 2026

Uh oh!

coderabbitai Bot Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		expect(normalizedFormDetailSource).toMatch(/<a href=\{form\.source\.url\}[^>]>[\s\S]Official/);
		expect(formDetailSource).toContain("Official");

Conversation

BigSimmo commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Uh oh!

supabase Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BigSimmo commented Jul 17, 2026 •

edited

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading